Reviewers: Yang,
Description:
Revert r18029.
Add counters for write barriers in generated code.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/84823003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -27 lines):
M src/arm/macro-assembler-arm.cc
M src/ia32/macro-assembler-ia32.cc
M src/mips/macro-assembler-mips.cc
M src/v8-counters.h
M src/x64/macro-assembler-x64.cc
Index: src/arm/macro-assembler-arm.cc
diff --git a/src/arm/macro-assembler-arm.cc b/src/arm/macro-assembler-arm.cc
index
65962e7fb7f50c3b6da96de139dcc9d26c13f523..47d42a3122073e988ee8985047244a19a51e8b67
100644
--- a/src/arm/macro-assembler-arm.cc
+++ b/src/arm/macro-assembler-arm.cc
@@ -516,12 +516,6 @@ void MacroAssembler::RecordWrite(Register object,
Check(eq, kWrongAddressOrValuePassedToRecordWrite);
}
- // Count number of write barriers in generated code.
- isolate()->counters()->write_barriers_static()->Increment();
- // TODO(mstarzinger): Dynamic counter missing.
-
- // First, check if a write barrier is even needed. The tests below
- // catch stores of smis and stores into the young generation.
Label done;
if (smi_check == INLINE_SMI_CHECK) {
Index: src/ia32/macro-assembler-ia32.cc
diff --git a/src/ia32/macro-assembler-ia32.cc
b/src/ia32/macro-assembler-ia32.cc
index
2d0720a77d208716b300c8a4346295bb3571a403..d394c098c61e13f80c61110c1edf84f010b70987
100644
--- a/src/ia32/macro-assembler-ia32.cc
+++ b/src/ia32/macro-assembler-ia32.cc
@@ -614,10 +614,6 @@ void MacroAssembler::RecordWriteForMap(
return;
}
- // Count number of write barriers in generated code.
- isolate()->counters()->write_barriers_static()->Increment();
- IncrementCounter(isolate()->counters()->write_barriers_dynamic(), 1);
-
// A single check of the map's pages interesting flag suffices, since it
is
// only set during incremental collection, and then it's also guaranteed
that
// the from object's page's interesting flag is also set. This
optimization
@@ -674,10 +670,6 @@ void MacroAssembler::RecordWrite(Register object,
bind(&ok);
}
- // Count number of write barriers in generated code.
- isolate()->counters()->write_barriers_static()->Increment();
- IncrementCounter(isolate()->counters()->write_barriers_dynamic(), 1);
-
// First, check if a write barrier is even needed. The tests below
// catch stores of Smis and stores into young gen.
Label done;
Index: src/mips/macro-assembler-mips.cc
diff --git a/src/mips/macro-assembler-mips.cc
b/src/mips/macro-assembler-mips.cc
index
04aa9c97153352fe1e6b2ed90bef636cd57b414c..cdfbae39c2a27242f7745cc9cd5d039d11060428
100644
--- a/src/mips/macro-assembler-mips.cc
+++ b/src/mips/macro-assembler-mips.cc
@@ -275,12 +275,6 @@ void MacroAssembler::RecordWrite(Register object,
eq, kWrongAddressOrValuePassedToRecordWrite, at, Operand(value));
}
- // Count number of write barriers in generated code.
- isolate()->counters()->write_barriers_static()->Increment();
- // TODO(mstarzinger): Dynamic counter missing.
-
- // First, check if a write barrier is even needed. The tests below
- // catch stores of smis and stores into the young generation.
Label done;
if (smi_check == INLINE_SMI_CHECK) {
Index: src/v8-counters.h
diff --git a/src/v8-counters.h b/src/v8-counters.h
index
54e8100bcce4a760b601a89507ed276cc7115cf0..55e1e5c8292f4962e4448475f3f8ea93410bfc9a
100644
--- a/src/v8-counters.h
+++ b/src/v8-counters.h
@@ -261,9 +261,6 @@ namespace internal {
SC(soft_deopts_requested, V8.SoftDeoptsRequested) \
SC(soft_deopts_inserted, V8.SoftDeoptsInserted) \
SC(soft_deopts_executed, V8.SoftDeoptsExecuted) \
- /* Number of write barriers in generated code. */ \
- SC(write_barriers_dynamic, V8.WriteBarriersDynamic) \
- SC(write_barriers_static, V8.WriteBarriersStatic) \
SC(new_space_bytes_available, V8.MemoryNewSpaceBytesAvailable) \
SC(new_space_bytes_committed, V8.MemoryNewSpaceBytesCommitted) \
SC(new_space_bytes_used, V8.MemoryNewSpaceBytesUsed) \
Index: src/x64/macro-assembler-x64.cc
diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc
index
49629c7fb1844cde089270dbc689ea65652bf9f1..25f4bd37301b6dd12fd777216f0991bd02f47e57
100644
--- a/src/x64/macro-assembler-x64.cc
+++ b/src/x64/macro-assembler-x64.cc
@@ -405,10 +405,6 @@ void MacroAssembler::RecordWrite(Register object,
bind(&ok);
}
- // Count number of write barriers in generated code.
- isolate()->counters()->write_barriers_static()->Increment();
- IncrementCounter(isolate()->counters()->write_barriers_dynamic(), 1);
-
// First, check if a write barrier is even needed. The tests below
// catch stores of smis and stores into the young generation.
Label done;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
