Reviewers: mvstanton,
Message:
Hey Michael,
Here's the red-only deserializer CL I just mentioned. PTAL :-)
-- Benedikt
Description:
Drop unused Assembler::set_external_target_at() method.
Please review this at https://codereview.chromium.org/85793002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -32 lines):
M src/arm/assembler-arm-inl.h
M src/arm/assembler-arm.h
M src/ia32/assembler-ia32.h
M src/mips/assembler-mips.h
M src/x64/assembler-x64.h
Index: src/arm/assembler-arm-inl.h
diff --git a/src/arm/assembler-arm-inl.h b/src/arm/assembler-arm-inl.h
index
24c5ccafdb974f192d883e2af181685c0161ec41..3399958ee3d1767b8f753b8a4309a6c24f15ffd9
100644
--- a/src/arm/assembler-arm-inl.h
+++ b/src/arm/assembler-arm-inl.h
@@ -457,12 +457,6 @@ void Assembler::deserialization_set_special_target_at(
}
-void Assembler::set_external_target_at(Address constant_pool_entry,
- Address target) {
- Memory::Address_at(constant_pool_entry) = target;
-}
-
-
static Instr EncodeMovwImmediate(uint32_t immediate) {
ASSERT(immediate < 0x10000);
return ((immediate & 0xf000) << 4) | (immediate & 0xfff);
Index: src/arm/assembler-arm.h
diff --git a/src/arm/assembler-arm.h b/src/arm/assembler-arm.h
index
137dd73e992549c5b3069b218b5ef8a2f5480fc7..afb0c62787a4ca5e22795179a0d0cb2079e97a7a
100644
--- a/src/arm/assembler-arm.h
+++ b/src/arm/assembler-arm.h
@@ -803,11 +803,6 @@ class Assembler : public AssemblerBase {
inline static void deserialization_set_special_target_at(
Address constant_pool_entry, Address target);
- // This sets the branch destination (which is in the constant pool on
ARM).
- // This is for calls and branches to runtime code.
- inline static void set_external_target_at(Address constant_pool_entry,
- Address target);
-
// Here we are patching the address in the constant pool, not the actual
call
// instruction. The address in the constant pool is the same size as a
// pointer.
Index: src/ia32/assembler-ia32.h
diff --git a/src/ia32/assembler-ia32.h b/src/ia32/assembler-ia32.h
index
ed7b71f922faa9a20a810e1ad293e5cbe7166b2d..6ed0bc6d6625d092fec6170a991d77123197c310
100644
--- a/src/ia32/assembler-ia32.h
+++ b/src/ia32/assembler-ia32.h
@@ -638,13 +638,6 @@ class Assembler : public AssemblerBase {
set_target_address_at(instruction_payload, target);
}
- // This sets the branch destination (which is in the instruction on x86).
- // This is for calls and branches to runtime code.
- inline static void set_external_target_at(Address instruction_payload,
- Address target) {
- set_target_address_at(instruction_payload, target);
- }
-
static const int kSpecialTargetSize = kPointerSize;
// Distance between the address of the code target in the call
instruction
Index: src/mips/assembler-mips.h
diff --git a/src/mips/assembler-mips.h b/src/mips/assembler-mips.h
index
49cce621efa2a48b89dd7250504a73a0fd304880..d9ef46cd01464903fe35b5e72d9c402863555755
100644
--- a/src/mips/assembler-mips.h
+++ b/src/mips/assembler-mips.h
@@ -537,13 +537,6 @@ class Assembler : public AssemblerBase {
target);
}
- // This sets the branch destination.
- // This is for calls and branches to runtime code.
- inline static void set_external_target_at(Address instruction_payload,
- Address target) {
- set_target_address_at(instruction_payload, target);
- }
-
// Size of an instruction.
static const int kInstrSize = sizeof(Instr);
Index: src/x64/assembler-x64.h
diff --git a/src/x64/assembler-x64.h b/src/x64/assembler-x64.h
index
ac69a240cc1e842ce7de4018469fd237f506f6e8..709b61b52ea9e3dabe48738f4b51027a6ccdea77
100644
--- a/src/x64/assembler-x64.h
+++ b/src/x64/assembler-x64.h
@@ -586,13 +586,6 @@ class Assembler : public AssemblerBase {
set_target_address_at(instruction_payload, target);
}
- // This sets the branch destination (which is a load instruction on x64).
- // This is for calls and branches to runtime code.
- inline static void set_external_target_at(Address instruction_payload,
- Address target) {
- *reinterpret_cast<Address*>(instruction_payload) = target;
- }
-
inline Handle<Object> code_target_object_handle_at(Address pc);
inline Address runtime_entry_at(Address pc);
// Number of bytes taken up by the branch target in the code.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
