Revision: 18055
Author: [email protected]
Date: Mon Nov 25 14:07:05 2013 UTC
Log: Drop unused Assembler::set_external_target_at() method.
[email protected]
Review URL: https://codereview.chromium.org/85793002
http://code.google.com/p/v8/source/detail?r=18055
Modified:
/branches/bleeding_edge/src/arm/assembler-arm-inl.h
/branches/bleeding_edge/src/arm/assembler-arm.h
/branches/bleeding_edge/src/ia32/assembler-ia32.h
/branches/bleeding_edge/src/mips/assembler-mips.h
/branches/bleeding_edge/src/x64/assembler-x64.h
=======================================
--- /branches/bleeding_edge/src/arm/assembler-arm-inl.h Tue Nov 19 06:39:36
2013 UTC
+++ /branches/bleeding_edge/src/arm/assembler-arm-inl.h Mon Nov 25 14:07:05
2013 UTC
@@ -455,12 +455,6 @@
Address constant_pool_entry, Address target) {
Memory::Address_at(constant_pool_entry) = target;
}
-
-
-void Assembler::set_external_target_at(Address constant_pool_entry,
- Address target) {
- Memory::Address_at(constant_pool_entry) = target;
-}
static Instr EncodeMovwImmediate(uint32_t immediate) {
=======================================
--- /branches/bleeding_edge/src/arm/assembler-arm.h Tue Nov 19 06:39:36
2013 UTC
+++ /branches/bleeding_edge/src/arm/assembler-arm.h Mon Nov 25 14:07:05
2013 UTC
@@ -803,11 +803,6 @@
inline static void deserialization_set_special_target_at(
Address constant_pool_entry, Address target);
- // This sets the branch destination (which is in the constant pool on
ARM).
- // This is for calls and branches to runtime code.
- inline static void set_external_target_at(Address constant_pool_entry,
- Address target);
-
// Here we are patching the address in the constant pool, not the actual
call
// instruction. The address in the constant pool is the same size as a
// pointer.
=======================================
--- /branches/bleeding_edge/src/ia32/assembler-ia32.h Mon Nov 18 15:24:41
2013 UTC
+++ /branches/bleeding_edge/src/ia32/assembler-ia32.h Mon Nov 25 14:07:05
2013 UTC
@@ -637,13 +637,6 @@
Address instruction_payload, Address target) {
set_target_address_at(instruction_payload, target);
}
-
- // This sets the branch destination (which is in the instruction on x86).
- // This is for calls and branches to runtime code.
- inline static void set_external_target_at(Address instruction_payload,
- Address target) {
- set_target_address_at(instruction_payload, target);
- }
static const int kSpecialTargetSize = kPointerSize;
=======================================
--- /branches/bleeding_edge/src/mips/assembler-mips.h Tue Nov 5 20:48:35
2013 UTC
+++ /branches/bleeding_edge/src/mips/assembler-mips.h Mon Nov 25 14:07:05
2013 UTC
@@ -536,13 +536,6 @@
instruction_payload - kInstructionsFor32BitConstant * kInstrSize,
target);
}
-
- // This sets the branch destination.
- // This is for calls and branches to runtime code.
- inline static void set_external_target_at(Address instruction_payload,
- Address target) {
- set_target_address_at(instruction_payload, target);
- }
// Size of an instruction.
static const int kInstrSize = sizeof(Instr);
=======================================
--- /branches/bleeding_edge/src/x64/assembler-x64.h Mon Nov 18 15:24:41
2013 UTC
+++ /branches/bleeding_edge/src/x64/assembler-x64.h Mon Nov 25 14:07:05
2013 UTC
@@ -585,13 +585,6 @@
Address instruction_payload, Address target) {
set_target_address_at(instruction_payload, target);
}
-
- // This sets the branch destination (which is a load instruction on x64).
- // This is for calls and branches to runtime code.
- inline static void set_external_target_at(Address instruction_payload,
- Address target) {
- *reinterpret_cast<Address*>(instruction_payload) = target;
- }
inline Handle<Object> code_target_object_handle_at(Address pc);
inline Address runtime_entry_at(Address pc);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
