Reviewers: Jakob,
Description:
Fix generate_trig_table build target.
It now closely resembles the js2c target, so that we only have
one platform to run it on (either 'host' or 'target'). This way
we do not run into warnings when compiling for e.g. ARM.
[email protected]
Please review this at https://codereview.chromium.org/85893002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -7 lines):
M tools/gyp/v8.gyp
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index
65d5fb89a9303fdee8865feaf6727e59c6303cea..37fd4075986cb8d7074f978402b8a5d7f872925d
100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -113,10 +113,15 @@
'dependencies': [
'mksnapshot.<(v8_target_arch)#host',
'js2c#host',
+ 'generate_trig_table#host',
],
}, {
'toolsets': ['target'],
- 'dependencies': ['mksnapshot.<(v8_target_arch)', 'js2c'],
+ 'dependencies': [
+ 'mksnapshot.<(v8_target_arch)',
+ 'js2c',
+ 'generate_trig_table',
+ ],
}],
['component=="shared_library"', {
'defines': [
@@ -189,10 +194,10 @@
'conditions': [
['want_separate_host_toolset==1', {
'toolsets': ['host', 'target'],
- 'dependencies': ['js2c#host'],
+ 'dependencies': ['js2c#host', 'generate_trig_table#host'],
}, {
'toolsets': ['target'],
- 'dependencies': ['js2c'],
+ 'dependencies': ['js2c', 'generate_trig_table'],
}],
['component=="shared_library"', {
'defines': [
@@ -206,7 +211,7 @@
'type': 'none',
'conditions': [
['want_separate_host_toolset==1', {
- 'toolsets': ['host', 'target'],
+ 'toolsets': ['host'],
}, {
'toolsets': ['target'],
}],
@@ -231,9 +236,6 @@
{
'target_name': 'v8_base.<(v8_target_arch)',
'type': 'static_library',
- 'dependencies': [
- 'generate_trig_table',
- ],
'variables': {
'optimize': 'max',
},
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
