LGTM with a nit. Furthermore (as discussed offline), we might consider
changing
all those
class Foo {
static Local<Foo> New(Isolate*, ...);
}
to
class Isolate {
Local<Foo> NewFoo(...);
}
This has pros and cons, but at least keep the possibility in mind.
https://codereview.chromium.org/84833006/diff/40001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/84833006/diff/40001/include/v8.h#newcode1997
include/v8.h:1997: static Local<Integer> New(int32_t value, Isolate*);
For consistency reasons, the Isolate parameter should come first. Same
below.
https://codereview.chromium.org/84833006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
