Reviewers: ulan,
Message:
-> and added a check that the string is flat when ExperimentalScanner gets
it.
https://codereview.chromium.org/88203002/diff/20001/src/lexer/experimental-scanner.cc
File src/lexer/experimental-scanner.cc (right):
https://codereview.chromium.org/88203002/diff/20001/src/lexer/experimental-scanner.cc#newcode36
src/lexer/experimental-scanner.cc:36: if (!scanners_)
On 2013/11/26 13:15:47, ulan wrote:
Either one line "if (!scanners_) return;" or add braces.
Done.
https://codereview.chromium.org/88203002/diff/20001/src/lexer/experimental-scanner.cc#newcode50
src/lexer/experimental-scanner.cc:50: template <>
On 2013/11/26 13:15:47, ulan wrote:
Separate functions with two empty lines.
Done.
Description:
Experimental scanner += API which takes Handle<String>.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/88203002/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/parser
Affected files (+131, -79 lines):
M src/lexer/experimental-scanner.h
A + src/lexer/experimental-scanner.cc
M src/lexer/lexer-shell.cc
M tools/gyp/v8.gyp
M tools/lexer_generator/code_generator.jinja
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
