LGTM with comment.
https://codereview.chromium.org/88343002/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):
https://codereview.chromium.org/88343002/diff/1/test/cctest/cctest.status#newcode67
test/cctest/cctest.status:67: 'test-api/Threading4': [PASS, ['mode ==
debug', SLOW]],
Threading* tests are a summary of essentially normal tests that are
defined using the THREADED_TEST macro instead of TEST. So we already
have single-threaded coverage on those tests, but run them
multi-threaded again. In order to reduce runtime, Threading tests are
divided into four parts. It just happens that parts 2 and 3 are somewhat
faster, but it seems arbitrary to me to mark only 1 and 4 as slow.
Imo we can remove all 4 parts.
Or divide them into more parts, but that probably wouldn't make the
total run time any faster.
https://codereview.chromium.org/88343002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
