[v8-dev] Avoid useless #ifdef DEBUG checks for the --trace-ic flag. (issue 91003002)

Wed, 27 Nov 2013 00:46:49 -0800 

Reviewers: Sven Panne,

Message:
PTAL

Description:
Avoid useless #ifdef DEBUG checks for the --trace-ic flag.

FLAG_trace_ic is constant false in non-DEBUG builds anyways.

Please review this at https://codereview.chromium.org/91003002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+0, -16 lines):
  M src/arm/ic-arm.cc
  M src/code-stubs.cc
  M src/ic.cc
  M src/mips/ic-mips.cc


Index: src/arm/ic-arm.cc
diff --git a/src/arm/ic-arm.cc b/src/arm/ic-arm.cc
index f93b04c53f2da95e296b9b155f618c834e0824c9..11a6145efdf25bf1dfaba894d8240cb73fcf58c1 100644 
--- a/src/arm/ic-arm.cc
+++ b/src/arm/ic-arm.cc
@@ -1641,12 +1641,10 @@ void PatchInlinedSmiCode(Address address, InlinedSmiCheck check) { 
     return;
   }

-#ifdef DEBUG
   if (FLAG_trace_ic) {
     PrintF("[  patching ic at %p, cmp=%p, delta=%d\n",
            address, cmp_instruction_address, delta);
   }
-#endif

   Address patch_address =
       cmp_instruction_address - delta * Instruction::kInstrSize;
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index 051dd45dd99273969a22591920b9484c539b13c3..87fca37e9b2f348d5862af9d92b8d912e47ce5aa 100644 
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -864,7 +864,6 @@ void HydrogenCodeStub::TraceTransition(StateType from, StateType to) { // Note: Although a no-op transition is semantically OK, it is hinting at a 
   // bug somewhere in our state transition machinery.
   ASSERT(from != to);
-  #ifdef DEBUG
   if (!FLAG_trace_ic) return;
   char buffer[100];
   NoAllocationStringAllocator allocator(buffer,
@@ -878,7 +877,6 @@ void HydrogenCodeStub::TraceTransition(StateType from, StateType to) { 
   to.Print(&stream);
   stream.Add("]\n");
   stream.OutputToStdOut();
-  #endif
 }


Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index c22f3c17d095af80825c45981b708c3a3ecc1177..2c83d569804a22ebc2eadeca8c52b12f1cf0f7d5 100644 
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -879,9 +879,7 @@ MaybeObject* LoadIC::Load(Handle<Object> object,
       }
       if (!stub.is_null()) {
         set_target(*stub);
-#ifdef DEBUG
         if (FLAG_trace_ic) PrintF("[LoadIC : +#length /stringwrapper]\n");
-#endif
       }
       // Get the string if we have a string wrapper object.
       String* string = String::cast(JSValue::cast(*object)->value());
@@ -904,9 +902,7 @@ MaybeObject* LoadIC::Load(Handle<Object> object,
       }
       if (!stub.is_null()) {
         set_target(*stub);
-#ifdef DEBUG
         if (FLAG_trace_ic) PrintF("[LoadIC : +#prototype /function]\n");
-#endif
       }
return *Accessors::FunctionGetPrototype(Handle<JSFunction>::cast(object)); 
     }
@@ -2360,7 +2356,6 @@ MaybeObject* BinaryOpIC::Transition(Handle<Object> left, Handle<Object> right) { 
   Maybe<Handle<Object> > result = stub.Result(left, right, isolate());
   if (!result.has_value) return Failure::Exception();

-#ifdef DEBUG
   if (FLAG_trace_ic) {
     char buffer[100];
     NoAllocationStringAllocator allocator(buffer,
@@ -2381,9 +2376,6 @@ MaybeObject* BinaryOpIC::Transition(Handle<Object> left, Handle<Object> right) { 
   } else {
     stub.UpdateStatus(left, right, result);
   }
-#else
-  stub.UpdateStatus(left, right, result);
-#endif

   Handle<Code> code = stub.GetCode(isolate());
   set_target(*code);
@@ -2612,7 +2604,6 @@ Code* CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) { 
   Handle<Code> new_target = stub.GetCode(isolate());
   set_target(*new_target);

-#ifdef DEBUG
   if (FLAG_trace_ic) {
     PrintF("[CompareIC in ");
     JavaScriptFrame::PrintTop(isolate(), stdout, false, true);
@@ -2626,7 +2617,6 @@ Code* CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) { 
            Token::Name(op_),
            static_cast<void*>(*stub.GetCode(isolate())));
   }
-#endif

   // Activate inlined smi code.
   if (previous_state == UNINITIALIZED) {
Index: src/mips/ic-mips.cc
diff --git a/src/mips/ic-mips.cc b/src/mips/ic-mips.cc
index 98fb2f7b469d40d1bd49f950e4e6c2b54a1c087e..506208055dff865612e0ead2e4c414c712617ccd 100644 
--- a/src/mips/ic-mips.cc
+++ b/src/mips/ic-mips.cc
@@ -1650,12 +1650,10 @@ void PatchInlinedSmiCode(Address address, InlinedSmiCheck check) { 
     return;
   }

-#ifdef DEBUG
   if (FLAG_trace_ic) {
     PrintF("[  patching ic at %p, andi=%p, delta=%d\n",
            address, andi_instruction_address, delta);
   }
-#endif

   Address patch_address =
       andi_instruction_address - delta * Instruction::kInstrSize;


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to