Revision: 18092
Author: [email protected]
Date: Wed Nov 27 09:24:42 2013 UTC
Log: Avoid useless #ifdef DEBUG checks for the --trace-ic flag.
FLAG_trace_ic is constant false in non-DEBUG builds anyways.
[email protected]
Review URL: https://codereview.chromium.org/91003002
http://code.google.com/p/v8/source/detail?r=18092
Modified:
/branches/bleeding_edge/src/arm/ic-arm.cc
/branches/bleeding_edge/src/code-stubs.cc
/branches/bleeding_edge/src/ic.cc
/branches/bleeding_edge/src/mips/ic-mips.cc
=======================================
--- /branches/bleeding_edge/src/arm/ic-arm.cc Mon Nov 18 13:07:44 2013 UTC
+++ /branches/bleeding_edge/src/arm/ic-arm.cc Wed Nov 27 09:24:42 2013 UTC
@@ -1641,12 +1641,10 @@
return;
}
-#ifdef DEBUG
if (FLAG_trace_ic) {
PrintF("[ patching ic at %p, cmp=%p, delta=%d\n",
address, cmp_instruction_address, delta);
}
-#endif
Address patch_address =
cmp_instruction_address - delta * Instruction::kInstrSize;
=======================================
--- /branches/bleeding_edge/src/code-stubs.cc Wed Nov 20 09:30:46 2013 UTC
+++ /branches/bleeding_edge/src/code-stubs.cc Wed Nov 27 09:24:42 2013 UTC
@@ -864,7 +864,6 @@
// Note: Although a no-op transition is semantically OK, it is hinting
at a
// bug somewhere in our state transition machinery.
ASSERT(from != to);
- #ifdef DEBUG
if (!FLAG_trace_ic) return;
char buffer[100];
NoAllocationStringAllocator allocator(buffer,
@@ -878,7 +877,6 @@
to.Print(&stream);
stream.Add("]\n");
stream.OutputToStdOut();
- #endif
}
=======================================
--- /branches/bleeding_edge/src/ic.cc Fri Nov 22 15:08:22 2013 UTC
+++ /branches/bleeding_edge/src/ic.cc Wed Nov 27 09:24:42 2013 UTC
@@ -879,9 +879,7 @@
}
if (!stub.is_null()) {
set_target(*stub);
-#ifdef DEBUG
if (FLAG_trace_ic) PrintF("[LoadIC : +#length /stringwrapper]\n");
-#endif
}
// Get the string if we have a string wrapper object.
String* string = String::cast(JSValue::cast(*object)->value());
@@ -904,9 +902,7 @@
}
if (!stub.is_null()) {
set_target(*stub);
-#ifdef DEBUG
if (FLAG_trace_ic) PrintF("[LoadIC : +#prototype /function]\n");
-#endif
}
return
*Accessors::FunctionGetPrototype(Handle<JSFunction>::cast(object));
}
@@ -2360,7 +2356,6 @@
Maybe<Handle<Object> > result = stub.Result(left, right, isolate());
if (!result.has_value) return Failure::Exception();
-#ifdef DEBUG
if (FLAG_trace_ic) {
char buffer[100];
NoAllocationStringAllocator allocator(buffer,
@@ -2381,9 +2376,6 @@
} else {
stub.UpdateStatus(left, right, result);
}
-#else
- stub.UpdateStatus(left, right, result);
-#endif
Handle<Code> code = stub.GetCode(isolate());
set_target(*code);
@@ -2612,7 +2604,6 @@
Handle<Code> new_target = stub.GetCode(isolate());
set_target(*new_target);
-#ifdef DEBUG
if (FLAG_trace_ic) {
PrintF("[CompareIC in ");
JavaScriptFrame::PrintTop(isolate(), stdout, false, true);
@@ -2626,7 +2617,6 @@
Token::Name(op_),
static_cast<void*>(*stub.GetCode(isolate())));
}
-#endif
// Activate inlined smi code.
if (previous_state == UNINITIALIZED) {
=======================================
--- /branches/bleeding_edge/src/mips/ic-mips.cc Mon Nov 18 13:07:44 2013 UTC
+++ /branches/bleeding_edge/src/mips/ic-mips.cc Wed Nov 27 09:24:42 2013 UTC
@@ -1650,12 +1650,10 @@
return;
}
-#ifdef DEBUG
if (FLAG_trace_ic) {
PrintF("[ patching ic at %p, andi=%p, delta=%d\n",
address, andi_instruction_address, delta);
}
-#endif
Address patch_address =
andi_instruction_address - delta * Instruction::kInstrSize;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
