https://codereview.chromium.org/61463005/diff/20001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/61463005/diff/20001/src/hydrogen-instructions.cc#newcode3390
src/hydrogen-instructions.cc:3390: HInstruction* current_instr =
HInstruction::cast(current_size);
HPhi can't happen here, since the current_size is either constant size
or a size calculation graph (const_header_size + const_element_size *
var_capacity). I'll add assert and comment instead.
https://codereview.chromium.org/61463005/diff/20001/src/hydrogen-instructions.cc#newcode3393
src/hydrogen-instructions.cc:3393: PrintF("#%d (%s) cannot fold into #%d
(%s), dynamic allocation size\n",
On 2013/11/14 12:50:13, Michael Starzinger wrote:
nit: The tracing text "dynamic allocation size" is ambiguous here.
Done.
https://codereview.chromium.org/61463005/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (left):
https://codereview.chromium.org/61463005/diff/20001/src/hydrogen.cc#oldcode2482
src/hydrogen.cc:2482: new_object->MakeDoubleAligned();
On 2013/11/14 10:04:20, mvstanton wrote:
Why was this removed, is it handled during the folding step?
This flag is set in the constructor of the HAllocate for fixed array.
And yes, the folding step takes care of that.
https://codereview.chromium.org/61463005/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/61463005/diff/20001/src/hydrogen.cc#newcode1925
src/hydrogen.cc:1925: int elements_size = IsFastDoubleElementsKind(kind)
On 2013/11/14 10:04:20, mvstanton wrote:
Ok, I removed manual constant folding code from here in this CL and in a
separate CL I'll make sure that constant folding works here as expected.
https://codereview.chromium.org/61463005/diff/20001/src/hydrogen.cc#newcode2448
src/hydrogen.cc:2448: // the JSArray allocation.
On 2013/11/14 10:04:20, mvstanton wrote:
Nice.
Done.
https://codereview.chromium.org/61463005/diff/20001/src/hydrogen.cc#newcode2480
src/hydrogen.cc:2480:
If two allocations folds together then the second one becomes
HInnerAllocation with all the benefits as before. Unfortunately, if the
allocations are not folded then write barrier is NOT eliminated.
https://codereview.chromium.org/61463005/diff/360001/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/61463005/diff/360001/src/hydrogen.h#newcode1674
src/hydrogen.h:1674: // array must have been allocated with enough room
for
On 2013/11/21 12:07:19, Hannes Payer wrote:
Can you change "array" to "Array".
Done.
https://codereview.chromium.org/61463005/diff/360001/src/hydrogen.h#newcode1675
src/hydrogen.h:1675: // 1) the JSArray, 2) a AllocationMemento if mode
requires it.
On 2013/11/21 12:07:19, Hannes Payer wrote:
-instead of "," -> "and"
-an AllocationMemento
Done.
https://codereview.chromium.org/61463005/diff/360001/src/objects-printer.cc
File src/objects-printer.cc (right):
https://codereview.chromium.org/61463005/diff/360001/src/objects-printer.cc#newcode952
src/objects-printer.cc:952:
CodeStub::MajorName(CodeStub::GetMajorKey(this), true));
Ok, I'll make a separate CL for that.
https://codereview.chromium.org/61463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
