On 2013/11/28 07:14:46, mvstanton wrote:
With the static assert, then lgtm.
https://codereview.chromium.org/46883009/diff/1/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/46883009/diff/1/src/hydrogen-check-elimination.cc#newcode398
src/hydrogen-check-elimination.cc:398: int16_t cursor_; // Must be <=
kMaxTrackedObjects
On 2013/10/31 11:16:13, mvstanton wrote:
> STATIC_ASSERT on sizeof cursor_ and size_ that they hold
kMaxTrackedObjects,
> since you are already reducing their size.
Ben asked: "where should I put this?"
I think right here next to the declaration, like
STATIC_ASSERT((1 << (sizeof(cursor_) * 8) >= kMaxTrackedObjects);
Done.
https://codereview.chromium.org/46883009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
