Reviewers: mvstanton,
Message:
PTAL
Description:
Remove strictmode from FindHandler.
Please review this at https://chromiumcodereview.appspot.com/95433002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -17 lines):
M src/ic.cc
M src/stub-cache.h
M src/stub-cache.cc
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index
9f55bd817bda3626715ffadba08df3d0899684f0..46820fe0c0f6c6b0223400e85151d1ea6cc9f310
100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -1178,12 +1178,8 @@ Handle<Code> IC::ComputeHandler(LookupResult* lookup,
Handle<HeapObject> stub_holder(GetCodeCacheHolder(
isolate(), *object, cache_holder));
- StrictModeFlag strict_mode = kNonStrictMode;
- if (kind() == Code::STORE_IC || kind() == Code::KEYED_STORE_IC) {
- strict_mode = StoreIC::GetStrictMode(extra_ic_state());
- }
Handle<Code> code = isolate()->stub_cache()->FindHandler(
- name, handle(stub_holder->map()), kind(), cache_holder, strict_mode);
+ name, handle(stub_holder->map()), kind(), cache_holder);
if (!code.is_null()) return code;
code = CompileHandler(lookup, object, name, value, cache_holder);
Index: src/stub-cache.cc
diff --git a/src/stub-cache.cc b/src/stub-cache.cc
index
3174f4b54a8f26e0b99b8329d2820bb59e59b64a..cb68b89efb37eb1d4d25b7ffb7d7d480a860f8b2
100644
--- a/src/stub-cache.cc
+++ b/src/stub-cache.cc
@@ -115,17 +115,9 @@ Handle<Code> StubCache::FindIC(Handle<Name> name,
Handle<Code> StubCache::FindHandler(Handle<Name> name,
Handle<Map> stub_holder,
Code::Kind kind,
- InlineCacheHolderFlag cache_holder,
- StrictModeFlag strict_mode) {
- ExtraICState extra_ic_state = kNoExtraICState;
- if (kind == Code::STORE_IC) {
- extra_ic_state = StoreIC::ComputeExtraICState(strict_mode);
- } else if (kind == Code::KEYED_STORE_IC) {
- extra_ic_state = KeyedStoreIC::ComputeExtraICState(strict_mode,
- STANDARD_STORE);
- }
+ InlineCacheHolderFlag cache_holder) {
Code::Flags flags = Code::ComputeMonomorphicFlags(
- Code::HANDLER, extra_ic_state, cache_holder, Code::NORMAL, kind);
+ Code::HANDLER, kNoExtraICState, cache_holder, Code::NORMAL, kind);
Handle<Object> probe(stub_holder->FindInCodeCache(*name, flags),
isolate_);
if (probe->IsCode()) return Handle<Code>::cast(probe);
Index: src/stub-cache.h
diff --git a/src/stub-cache.h b/src/stub-cache.h
index
7352e28519fb2a8d196239f166554521866a1a32..c70b1ff6187e1057d3abad95a08decbf04769899
100644
--- a/src/stub-cache.h
+++ b/src/stub-cache.h
@@ -89,8 +89,7 @@ class StubCache {
Handle<Code> FindHandler(Handle<Name> name,
Handle<Map> map,
Code::Kind kind,
- InlineCacheHolderFlag cache_holder = OWN_MAP,
- StrictModeFlag strict_mode = kNonStrictMode);
+ InlineCacheHolderFlag cache_holder = OWN_MAP);
Handle<Code> ComputeMonomorphicIC(Handle<Name> name,
Handle<Type> type,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
