I had your suggested option in mind, but chose this one to avoid similar issues in the future. I'll prepare a fix following your suggestion. On Nov 28, 2013 5:01 PM, <[email protected]> wrote:
> Unfortunately not LGTM. > > > https://codereview.chromium.org/95123003/diff/30001/src/hydrogen.cc > File src/hydrogen.cc (right): > > https://codereview.chromium.org/95123003/diff/30001/src/ > hydrogen.cc#newcode7567 > src/hydrogen.cc:7567: return false; > I don't think it is safe to bail out at this point, this will cause > prop->obj() to be visited twice. That might be an arbitrary complex > expression (maybe with side-effects). IMHO, the correct fix is further > down ... > > https://codereview.chromium.org/95123003/diff/30001/src/ > hydrogen.cc#newcode7600 > src/hydrogen.cc:7600: if (function->IsConstant()) { > ... here, because that is the only place where the constant function is > actually inspected unsafely. > > https://codereview.chromium.org/95123003/ > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
