Revision: 18141
Author: [email protected]
Date: Thu Nov 28 18:13:30 2013 UTC
Log: Remove strictmode from FindHandler.
[email protected]
Review URL: https://chromiumcodereview.appspot.com/95433002
http://code.google.com/p/v8/source/detail?r=18141
Modified:
/branches/bleeding_edge/src/ic.cc
/branches/bleeding_edge/src/stub-cache.cc
/branches/bleeding_edge/src/stub-cache.h
=======================================
--- /branches/bleeding_edge/src/ic.cc Thu Nov 28 15:32:55 2013 UTC
+++ /branches/bleeding_edge/src/ic.cc Thu Nov 28 18:13:30 2013 UTC
@@ -1178,12 +1178,8 @@
Handle<HeapObject> stub_holder(GetCodeCacheHolder(
isolate(), *object, cache_holder));
- StrictModeFlag strict_mode = kNonStrictMode;
- if (kind() == Code::STORE_IC || kind() == Code::KEYED_STORE_IC) {
- strict_mode = StoreIC::GetStrictMode(extra_ic_state());
- }
Handle<Code> code = isolate()->stub_cache()->FindHandler(
- name, handle(stub_holder->map()), kind(), cache_holder, strict_mode);
+ name, handle(stub_holder->map()), kind(), cache_holder);
if (!code.is_null()) return code;
code = CompileHandler(lookup, object, name, value, cache_holder);
=======================================
--- /branches/bleeding_edge/src/stub-cache.cc Thu Nov 28 18:11:15 2013 UTC
+++ /branches/bleeding_edge/src/stub-cache.cc Thu Nov 28 18:13:30 2013 UTC
@@ -115,17 +115,9 @@
Handle<Code> StubCache::FindHandler(Handle<Name> name,
Handle<Map> stub_holder,
Code::Kind kind,
- InlineCacheHolderFlag cache_holder,
- StrictModeFlag strict_mode) {
- ExtraICState extra_ic_state = kNoExtraICState;
- if (kind == Code::STORE_IC) {
- extra_ic_state = StoreIC::ComputeExtraICState(strict_mode);
- } else if (kind == Code::KEYED_STORE_IC) {
- extra_ic_state = KeyedStoreIC::ComputeExtraICState(strict_mode,
- STANDARD_STORE);
- }
+ InlineCacheHolderFlag cache_holder) {
Code::Flags flags = Code::ComputeMonomorphicFlags(
- Code::HANDLER, extra_ic_state, cache_holder, Code::NORMAL, kind);
+ Code::HANDLER, kNoExtraICState, cache_holder, Code::NORMAL, kind);
Handle<Object> probe(stub_holder->FindInCodeCache(*name, flags),
isolate_);
if (probe->IsCode()) return Handle<Code>::cast(probe);
=======================================
--- /branches/bleeding_edge/src/stub-cache.h Thu Nov 28 15:32:55 2013 UTC
+++ /branches/bleeding_edge/src/stub-cache.h Thu Nov 28 18:13:30 2013 UTC
@@ -89,8 +89,7 @@
Handle<Code> FindHandler(Handle<Name> name,
Handle<Map> map,
Code::Kind kind,
- InlineCacheHolderFlag cache_holder = OWN_MAP,
- StrictModeFlag strict_mode = kNonStrictMode);
+ InlineCacheHolderFlag cache_holder = OWN_MAP);
Handle<Code> ComputeMonomorphicIC(Handle<Name> name,
Handle<Type> type,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
