Reviewers: Toon Verwaest,

Message:
In the /usr/include/stdint.h on Mac,

#ifndef _INT64_T
#define _INT64_T
typedef long long            int64_t;
#endif /* _INT64_T */

"
#define INT64_C(v)   (v ## LL)
#define UINT64_C(v)  (v ## ULL)
"

I found this as https://codereview.chromium.org/91333002/ could not build in Mac as the movq does not choose int64_t and uint64_t and it wants long and unsigned
long.

Description:
Use ULL and LL suffix for uint64_t and int64_t constants on Mac

Please review this at https://codereview.chromium.org/96623002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+7, -2 lines):
  M src/globals.h


Index: src/globals.h
diff --git a/src/globals.h b/src/globals.h
index db80a7e584d33a7d9685c3d2e4fd668599c42f8f..bac8edf4852b72e46f6ea7853726af2f6f9c6d78 100644
--- a/src/globals.h
+++ b/src/globals.h
@@ -187,8 +187,13 @@ typedef byte* Address;
 # define V8_INTPTR_C(x)   (x ## LL)
 # define V8_PTR_PREFIX    "I64"
 #elif V8_HOST_ARCH_64_BIT
-# define V8_UINT64_C(x)   (x ## UL)
-# define V8_INT64_C(x)    (x ## L)
+# if defined(__APPLE__) && defined(__MACH__)
+#  define V8_UINT64_C(x)   (x ## ULL)
+#  define V8_INT64_C(x)    (x ## LL)
+# else
+#  define V8_UINT64_C(x)   (x ## UL)
+#  define V8_INT64_C(x)    (x ## L)
+# endif
 # define V8_INTPTR_C(x)   (x ## L)
 # define V8_PTR_PREFIX    "l"
 #else


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to