Will lgtm after you fix notes ))
https://codereview.chromium.org/96763002/diff/20001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://codereview.chromium.org/96763002/diff/20001/src/arm/stub-cache-arm.cc#newcode2341
src/arm/stub-cache-arm.cc:2341: if (!object.is_null() &&
object->IsGlobalObject()) {
Do we still need is_null() check here? (same note for ia32, x64 and
mips)
https://codereview.chromium.org/96763002/diff/20001/src/mips/stub-cache-mips.cc
File src/mips/stub-cache-mips.cc (right):
https://codereview.chromium.org/96763002/diff/20001/src/mips/stub-cache-mips.cc#newcode1029
src/mips/stub-cache-mips.cc:1029:
stub_compiler_->GenerateJumpFunction(object, function);
JumpIgnoreReceiver?
https://codereview.chromium.org/96763002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
