A couple comments. Very cool stuff.
--Michael
https://codereview.chromium.org/96783002/diff/50001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/96783002/diff/50001/src/heap.cc#newcode1941
src/heap.cc:1941:
casted->dependent_code()->DeoptimizeDependentCodeGroup(
This is a good thing, but don't you also need to reset the
pretenure_decision field in the allocation site? I think right now it
won't know that the decision needs to be revisited.
In fact, maybe there should be a method in AllocationSite that does
these two things, like ResetPretenureDecision(), which would naturally
enough deopt any code that depends on the previous value of that
decision.
https://codereview.chromium.org/96783002/diff/50001/src/heap.cc#newcode1949
src/heap.cc:1949: void Heap::EvaluateLocalPretenuring(int64_t
objects_before_gc) {
objects_before_gc: Can you get "sizeof" in the name of this variable?
I'm confused about what it is...# of objects, total byte size of them,
etc.
https://codereview.chromium.org/96783002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
