[v8-dev] Experimental parser: set start_ properly after illegal token. (issue 98843002)

Mon, 02 Dec 2013 02:46:04 -0800 

Reviewers: dcarney,

Message:
Committed patchset #1 manually as r18176.

Description:
Experimental parser: set start_ properly after illegal token.

Also, misc test file fixes.

[email protected]
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=18176

Please review this at https://codereview.chromium.org/98843002/

SVN Base: https://v8.googlecode.com/svn/branches/experimental/parser

Affected files (+8, -1 lines):
  M test/lexer/cornercases/harmony-number-and-identifier.js
  M test/lexer/cornercases/utf-endlines.js
  M test/lexer/utf-2.js
  M tools/lexer_generator/code_generator.jinja


Index: test/lexer/cornercases/harmony-number-and-identifier.js
diff --git a/test/lexer/cornercases/harmony-number-and-identifier.js b/test/lexer/cornercases/harmony-number-and-identifier.js index 592b867ed36239ad770598f0603268259eee074f..e3d9e68d1aa0c34e8654939279f1b58d7f76531b 100644 
--- a/test/lexer/cornercases/harmony-number-and-identifier.js
+++ b/test/lexer/cornercases/harmony-number-and-identifier.js
@@ -25,6 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+// Flags: --use-harmony
+
 // Harmony numeric literals.
 0b1101 0B1101 0o1234 0O1234

Index: test/lexer/cornercases/utf-endlines.js
diff --git a/test/lexer/cornercases/utf-endlines.js b/test/lexer/cornercases/utf-endlines.js index d5987db6cddca3f92449732d4153fd86252b73af..346941b73a6318cd031751aea69f83243b9b158c 100644 
--- a/test/lexer/cornercases/utf-endlines.js
+++ b/test/lexer/cornercases/utf-endlines.js
@@ -25,6 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+// Flags: --utf8to16
+
// The "-->" at the beginning of a line is a weird SpiderMonkey compatibility 
 // hack.

Index: test/lexer/utf-2.js
diff --git a/test/lexer/utf-2.js b/test/lexer/utf-2.js
index f0bfbadb650344b0b7533e56101ae44d5f744ca1..ed307137540260b117121eb7eac4b6ede602395f 100644 
--- a/test/lexer/utf-2.js
+++ b/test/lexer/utf-2.js
@@ -25,6 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+// Flags: --utf8to16
+
 // This file is in utf-8, and contains weird letters.

 // These letters are ok in identifiers.
Index: tools/lexer_generator/code_generator.jinja
diff --git a/tools/lexer_generator/code_generator.jinja b/tools/lexer_generator/code_generator.jinja index be3a700e63bfd2425cca4401bec6d8d15e906a1b..d029e2ad9367911309c98874b6fae3418e21843d 100644 
--- a/tools/lexer_generator/code_generator.jinja
+++ b/tools/lexer_generator/code_generator.jinja
@@ -173,7 +173,7 @@
   {%- endif %}

   {% if debug_print %}
-    fprintf(stderr, "state {{state.node_number}}\n");
+ fprintf(stderr, "state {{state.node_number}}, start %d, cursor %d\n", start_ - buffer_, cursor_ - buffer_); 
   {% endif -%}

   {%- set entry_action = state.entry_action -%}
@@ -262,6 +262,7 @@
   PREPARE_TOKEN();                    \
   FORWARD();                          \
   next_.token = T;                    \
+  start_ = cursor_;                   \
   return;                             \
 }



--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to