https://codereview.chromium.org/98963002/diff/1/Makefile
File Makefile (right):
https://codereview.chromium.org/98963002/diff/1/Makefile#newcode363
Makefile:363: --arch-and-mode=$(FASTTESTMODES) $(TESTFLAGS)
Like that, flaky tests are not skipped anymore when testing release
builds. I think skipping them here is important, not only for speed but
also for reliability. How about a --quickcheck flag for the test driver
instead?
https://codereview.chromium.org/98963002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/98963002/diff/1/tools/run-tests.py#newcode349
tools/run-tests.py:349:
This overwrites the global options dependent on the execution order. The
execution order can be specified by arch_and_mode. So, whether or not an
optdebug build comes first influences the test behavior afterwards.
https://codereview.chromium.org/98963002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
