LGTM with a couple of nits.
https://codereview.chromium.org/99193002/diff/1/include/v8.h
File include/v8.h (left):
https://codereview.chromium.org/99193002/diff/1/include/v8.h#oldcode3034
include/v8.h:3034: * A specialization of Value::NumberValue that is more
efficient
Why do we remove this comment, I liked it, can we have it back? Also the
empty new-lines between method declaration make it easier to read IMHO.
Same applies to NumberObject, BooleanObject, StringObject and
SymbolObject below.
https://codereview.chromium.org/99193002/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/99193002/diff/1/include/v8.h#newcode1929
include/v8.h:1929:
nit: Only one empty new-line withing class body.
https://codereview.chromium.org/99193002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
