On 2013/12/03 15:42:43, titzer wrote:
https://codereview.chromium.org/99013003/diff/20001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/99013003/diff/20001/src/runtime.cc#newcode8671
src/runtime.cc:8671: if
(static_cast<uint32_t>(unoptimized->instruction_size())
<= pc_offset) {
I don't see how this check is strict enough. I think you want to check
that
unoptimized code from the shared function info contains the passed PC.
Actually,
I think you might need to rework the runtime call for that.
I changed this as suggested. Now we no longer compute the offset in the
builtin,
but in the runtime function. Crawling the stack for the PC should be cheap.
https://codereview.chromium.org/99013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
