https://codereview.chromium.org/101783005/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/101783005/diff/1/src/hydrogen-instructions.cc#newcode4272
src/hydrogen-instructions.cc:4272: HObjectAccess
HObjectAccess::ForAllocationSiteOffset(int offset) {
I'd prefer to have one method per allocation site field, just as we do
for the other object types. This would be cleaner IMHO and less likely
to break (the fact that we need a switch here is already an indicator
that it'll break at some point).
https://codereview.chromium.org/101783005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
