Reviewers: machenbach,
Message:
With this, the global makefile wouldn't have to set `builddir` in the
`buildbot`
target either (but that target isn't used any more).
If this lgty, you probably have to land this yourself since this is
probably off
the wrong branch (?)
Description:
Pass -Goutput_dir=. to the make generator.
This makes it possible to remove the builddir_name hack added in r238632.
BUG=315004
Please review this at https://codereview.chromium.org/105563004/
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files (+4, -0 lines):
M build/gyp_v8
Index: build/gyp_v8
===================================================================
--- build/gyp_v8 (revision 18076)
+++ build/gyp_v8 (working copy)
@@ -167,5 +167,9 @@
# Generate for the architectures supported on the given platform.
gyp_args = list(args)
if platform.system() == 'Linux':
+ # --generator-output defines where the Makefile goes.
gyp_args.append('--generator-output=out')
+ # -Goutput_dir defines where the build output goes, relative to the
+ # Makefile. Set it to . so that the build output doesn't end up in
out/out.
+ gyp_args.append('-Goutput_dir=.')
run_gyp(gyp_args)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
