Reviewers: Jakob,
Message:
PTAL
Description:
Pass -Goutput_dir=. to the make generator.
This makes it possible to remove the builddir_name hack added in r238632.
BUG=315004
Patch from Nico Weber <[email protected]>.
Please review this at https://codereview.chromium.org/98753003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -0 lines):
M build/gyp_v8
Index: build/gyp_v8
diff --git a/build/gyp_v8 b/build/gyp_v8
index
92e6503925cda4c72245821bff6061c9dd593429..40c377de61581239d6f0d208171553c54fe6b54d
100755
--- a/build/gyp_v8
+++ b/build/gyp_v8
@@ -167,5 +167,9 @@ if __name__ == '__main__':
# Generate for the architectures supported on the given platform.
gyp_args = list(args)
if platform.system() == 'Linux':
+ # --generator-output defines where the Makefile goes.
gyp_args.append('--generator-output=out')
+ # -Goutput_dir defines where the build output goes, relative to the
+ # Makefile. Set it to . so that the build output doesn't end up in
out/out.
+ gyp_args.append('-Goutput_dir=.')
run_gyp(gyp_args)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
