Reviewers: danno, dcarney, Vyacheslav Egorov (Google),
Message:
Thanks for review.
Landing.
https://codereview.chromium.org/102063004/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/102063004/diff/1/test/cctest/test-api.cc#newcode21057
test/cctest/test-api.cc:21057: #endif // V8_OS_POSIX
On 2013/12/05 08:06:28, dcarney wrote:
you've got this inside the V8_OS_POSIX ifdef, which I presume is
wrong? That
#endif is already in the wrong spot itself...
Thanks! Copy&paste mistake. Fixed.
Description:
Introduce API to temporarily interrupt long running JavaScript code.
It is different from termination API as interrupted JavaScript will
continue to
execute normally when registered InterruptCallback returns.
/**
* Request V8 to interrupt long running JavaScript code and invoke
* the given |callback| passing the given |data| to it. After |callback|
* returns control will be returned to the JavaScript code.
* At any given moment V8 can remember only a single callback for the very
* last interrupt request.
* Can be called from another thread without acquiring a |Locker|.
* Registered |callback| must not reenter interrupted Isolate.
*/
void RequestInterrupt(InterruptCallback callback, void* data);
/**
* Clear interrupt request created by |RequestInterrupt|.
* Can be called from another thread without acquiring a |Locker|.
*/
void ClearInterrupt();
Fix Hydrogen SCE pass to avoid eliminating stack guards too aggressively.
Only
normal JavaScript functions are guaranteed to have stack guard in the
prologue.
If function is a builtin or has a custom call IC it will lack one.
BUG=
Please review this at https://codereview.chromium.org/102063004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+360, -5 lines):
M include/v8.h
M src/api.cc
M src/execution.h
M src/execution.cc
M src/hydrogen-instructions.h
M src/hydrogen-sce.cc
M test/cctest/test-api.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
