On 2013/12/06 09:46:16, mvstanton wrote:
One nit, and LGTM.
https://codereview.chromium.org/106733002/diff/1/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/106733002/diff/1/src/hydrogen-check-elimination.cc#newcode155
src/hydrogen-check-elimination.cc:155: HCheckTableEntry* le =
copy->Find(left),
*re = copy->Find(right);
nit: I prefer variable initialization on their own lines, so:
HCheckTableEntry* le = copy->Find(left);
HCheckTableEntry* re = copy->Find(right);
Done.
https://codereview.chromium.org/106733002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
