Overall I'm not too happy with the current approach. It looks like a hack
to get
this code in as quickly as possible. Can we find a less entangled way to get
this done?
https://codereview.chromium.org/107613003/diff/1/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/107613003/diff/1/src/ast.h#newcode1787
src/ast.h:1787: ElementsKind elements_kind() const { return
elements_kind_; }
I don't think this belongs on the generic Call expression at all. Can
you come up with a better way to plug this information in?
https://codereview.chromium.org/107613003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/107613003/diff/1/src/hydrogen.cc#newcode7755
src/hydrogen.cc:7755: if
(CallStubCompiler::HasCustomCallGenerator(expr->target())) {
Ugh. Can you please factor this out into a proper abstraction?
https://codereview.chromium.org/107613003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/107613003/diff/1/src/objects.cc#newcode10634
src/objects.cc:10634: return NULL;
Can you combine this code with the code above?
https://codereview.chromium.org/107613003/diff/1/src/type-info.cc
File src/type-info.cc (right):
https://codereview.chromium.org/107613003/diff/1/src/type-info.cc#newcode694
src/type-info.cc:694: Cell* cell = target->FindFirstCell();
If there's no cell, but we are contextual, we don't gather anything?
Don't we need to know anymore what we are calling? Or is this info
embedded in the cell somehow as well?
Is this because contextual calls are handled entirely differently from
normal ICs? If so, can we please first find a way to unify that code
before having even more special cases in different places?
https://codereview.chromium.org/107613003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
