https://codereview.chromium.org/108413003/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/108413003/diff/1/src/hydrogen-instructions.h#newcode6571
src/hydrogen-instructions.h:6571: void set_can_omit_smi_tag_store(bool
v) { can_omit_smi_tag_store_ = v; }
On 2013/12/09 15:51:10, Toon Verwaest wrote:
I'd rather distinguish between "initializing stores" and stores to
existing
fields.
// Indicates whether this is a store to a field that was previously
initialized
to a value of the same representation.
bool store_to_initialized_field();
Good suggestion! Done.
https://codereview.chromium.org/108413003/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/108413003/diff/1/src/x64/lithium-codegen-x64.cc#newcode4011
src/x64/lithium-codegen-x64.cc:4011: __
movl(FieldOperand(write_register, offset), kScratchRegister);
On 2013/12/09 15:51:10, Toon Verwaest wrote:
What about just shifting up the value and storing the entire 64 bits
if you need
to clear? Seems like that should be at least shorter in number of
instruction
bytes.
Especially if the value is constant. In that case you can just load
the entire
constant in a register and write that in 1 go. You shouldn't need
kScratchRegisterContainsZero.
Done.
https://codereview.chromium.org/108413003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
