Revision: 18284
Author: [email protected]
Date: Tue Dec 10 09:44:44 2013 UTC
Log: Increase number of available major keys.
This also adds a static assert checking that we do not
exceed the available number of major keys. The safepoint
table offset is now max 2^24 instead of 2^25.
[email protected]
Review URL: https://codereview.chromium.org/110183003
http://code.google.com/p/v8/source/detail?r=18284
Modified:
/branches/bleeding_edge/src/code-stubs.h
/branches/bleeding_edge/src/objects.h
=======================================
--- /branches/bleeding_edge/src/code-stubs.h Mon Dec 2 13:14:07 2013 UTC
+++ /branches/bleeding_edge/src/code-stubs.h Tue Dec 10 09:44:44 2013 UTC
@@ -245,6 +245,7 @@
MajorKeyBits::encode(MajorKey());
}
+ STATIC_ASSERT(NUMBER_OF_IDS < (1 << kStubMajorKeyBits));
class MajorKeyBits: public BitField<uint32_t, 0, kStubMajorKeyBits> {};
class MinorKeyBits: public BitField<uint32_t,
kStubMajorKeyBits, kStubMinorKeyBits> {}; // NOLINT
=======================================
--- /branches/bleeding_edge/src/objects.h Wed Dec 4 11:39:24 2013 UTC
+++ /branches/bleeding_edge/src/objects.h Tue Dec 10 09:44:44 2013 UTC
@@ -311,7 +311,7 @@
// Instance size sentinel for objects of variable size.
const int kVariableSizeSentinel = 0;
-const int kStubMajorKeyBits = 6;
+const int kStubMajorKeyBits = 7;
const int kStubMinorKeyBits = kBitsPerInt - kSmiTagSize -
kStubMajorKeyBits;
// All Maps have a field instance_type containing a InstanceType.
@@ -5484,7 +5484,7 @@
static const int kStubMajorKeyFirstBit = kIsCrankshaftedBit + 1;
static const int kSafepointTableOffsetFirstBit =
kStubMajorKeyFirstBit + kStubMajorKeyBits;
- static const int kSafepointTableOffsetBitCount = 25;
+ static const int kSafepointTableOffsetBitCount = 24;
STATIC_ASSERT(kStubMajorKeyFirstBit + kStubMajorKeyBits <= 32);
STATIC_ASSERT(kSafepointTableOffsetFirstBit +
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
