On 2013/12/06 09:08:38, Jakob wrote:
LGTM with comment.
Since the bug is about a test-only failure, I've also set LOG=N.
https://codereview.chromium.org/106853002/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/106853002/diff/1/src/x64/code-stubs-x64.cc#newcode4341
src/x64/code-stubs-x64.cc:4341: FLAG_debug_code ? Label::kFar :
Label::kNear);
nit: I'd prefer to keep the effect of FLAG_debug_code on emitted code to a
minimum. Let's just always use Label::kFar here. (Since that's the
default,
you
can also just skip the explicit parameter; but please do keep the comment
to
warn future contributors.)
Sheriff's note: permission to land
https://codereview.chromium.org/106853002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
