Reviewers: rossberg,

Description:
Typing pass: check stack overflow before recursing.

BUG=

Please review this at https://codereview.chromium.org/110913004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+2, -4 lines):
  M src/typing.cc


Index: src/typing.cc
diff --git a/src/typing.cc b/src/typing.cc
index 8487c05eb4af9fe472509c5afc34ae0eb1916053..6e408869730053d538d6de2441624c8e8f52325b 100644
--- a/src/typing.cc
+++ b/src/typing.cc
@@ -48,9 +48,8 @@ AstTyper::AstTyper(CompilationInfo* info)

 #define RECURSE(call)                         \
   do {                                        \
-    ASSERT(!visitor->HasStackOverflow());     \
-    call;                                     \
     if (visitor->HasStackOverflow()) return;  \
+    call;                                     \
   } while (false)

 void AstTyper::Run(CompilationInfo* info) {
@@ -70,9 +69,8 @@ void AstTyper::Run(CompilationInfo* info) {

 #define RECURSE(call)                \
   do {                               \
-    ASSERT(!HasStackOverflow());     \
-    call;                            \
     if (HasStackOverflow()) return;  \
+    call;                            \
   } while (false)




--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to