On 2013/12/11 10:09:31, Jakob wrote:
Generally, s/armv7==1/arm_version==7/ is fine.
However, we intentionally had the unspecified default mode, meaning "let
my
compiler decide". AFAIK this was mostly used by people building natively
on
ARM
machines. I don't want to break or degrade that use case.
Changed the default of arm_version to "default", and added back conditions
corresponding to the original armv7=="default" checks.
Please also update the top-level Makefile,
https://code.google.com/p/v8/source/browse/branches/bleeding_edge/Makefile#141
ff. It would be nice to keep the armv7=true/false command-line flag for a
while
for compatibility reasons, and add a new arm_version=FOO in addition.
Done. I wasn't quite sure what armv7=0 should map to, so I went with
arm_version=default, but I guess arm_version=6 might also be suitable- what
do
you think?
https://codereview.chromium.org/98543008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
