On 2013/12/04 13:06:25, Toon Verwaest wrote:
Looking good. Just one comment.
https://codereview.chromium.org/100613004/diff/60001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/100613004/diff/60001/src/runtime.cc#newcode8695
src/runtime.cc:8695:
function->shared()->InstallFromOptimizedCodeMap(*function,
cached_index);
I'd prefer to have a single choke-point that sets up the function for OSR,
that
would be used from both newly OSRd functions and functions OSRd using
cached
code. That way it'll be easier to find this place, to change it so that it
doesn't install the OSR code into the function.
Abandoned in favor of https://codereview.chromium.org/101853003/
https://codereview.chromium.org/100613004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
