Superficially LGTM with nits.
I leave the in-depth review to Ilya/Alexei.
https://codereview.chromium.org/103893003/diff/1/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/103893003/diff/1/src/cpu-profiler.cc#newcode180
src/cpu-profiler.cc:180: // If this was the last profile, clean up all
accessory data as well.
nit: indentation
https://codereview.chromium.org/103893003/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/103893003/diff/1/test/cctest/test-cpu-profiler.cc#newcode1552
test/cctest/test-cpu-profiler.cc:1552: v8::Handle<v8::String> innter =
v8::String::NewFromUtf8(isolate, "inner");
nit: I think you mean s/innter/inner/
https://codereview.chromium.org/103893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
