LGTM in principle, but I would like to see Rodolph's comments regarding the
performance impact, too.
https://codereview.chromium.org/100483006/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/100483006/diff/1/src/arm/lithium-codegen-arm.cc#newcode1418
src/arm/lithium-codegen-arm.cc:1418: __ cmp(right, Operand(-1), eq);
Is conditional non-execution of 2 instructions really better than a
probably correctly predicted jump around them? I think it is (IIRC the
threshold was around 3 instructions), but I'll let our ARM black belts
decide... :-)
https://codereview.chromium.org/100483006/diff/1/src/arm/lithium-codegen-arm.cc#newcode1519
src/arm/lithium-codegen-arm.cc:1519: __ cmp(right, Operand(-1), eq);
Same here...
https://codereview.chromium.org/100483006/diff/1/src/arm/lithium-codegen-arm.cc#newcode3445
src/arm/lithium-codegen-arm.cc:3445: __ ldr(result, MemOperand(fp,
StandardFrameConstants::kCallerFPOffset), ne);
... and here (3 instructions now)
https://codereview.chromium.org/100483006/diff/1/src/arm/lithium-codegen-arm.cc#newcode3875
src/arm/lithium-codegen-arm.cc:3875: __ vadd(result, input,
kDoubleRegZero, ne);
... and here.
https://codereview.chromium.org/100483006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
