LGTM, minor nits
https://codereview.chromium.org/108443004/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/108443004/diff/1/src/objects-inl.h#newcode3921
src/objects-inl.h:3921: }
Can we have 2 newlines here?
https://codereview.chromium.org/108443004/diff/1/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/108443004/diff/1/src/stub-cache.cc#newcode1103
src/stub-cache.cc:1103: if (code->has_major_key()) {
I think it would make sense to set the major key in CreateCode.
https://codereview.chromium.org/108443004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
