Reviewers: Hannes Payer,
Message:
Hi Hannes, here is the adjustment to metrics we discussed. thx,
--Michael
Description:
Pretenuring calculation improvement in DigestPretenuringFeedback().
If only a few objects are created from a full-code site every gc,
it's possible that we won't reach a pretenuring decision because
we require a minimum number of created objects in order to make
that decision. Allow the number of created objects from an allocation
site to grow across gcs if we are still undecided.
Please review this at https://codereview.chromium.org/115123003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -1 lines):
M src/objects-inl.h
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index
1717a5f4b59a8cba4db473b0e0634e9c9c437b93..ba72062eb0865d079d8aa6699142b5653e707d39
100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -1414,7 +1414,9 @@ inline bool
AllocationSite::DigestPretenuringFeedback() {
// Clear feedback calculation fields until the next gc.
set_memento_found_count(Smi::FromInt(0));
- set_memento_create_count(Smi::FromInt(0));
+ if (decision_made) {
+ set_memento_create_count(Smi::FromInt(0));
+ }
return decision_made;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
