On 2013/12/16 12:53:53, Sven Panne wrote:
lgtm
https://chromiumcodereview.appspot.com/107543003/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://chromiumcodereview.appspot.com/107543003/diff/1/src/serialize.cc#newcode799
src/serialize.cc:799: while (it.has_next()) {
Not directly your code, but I need a place to whine: We should really,
really
unify the tons of different iterators and iterator-like interfaces to
something
STL-like. We have dozens of useless variations, and the one at hand makes
it
basically impossible to use a (more readable) for-loop or something from
<algorithm>. :-(
</EndOfWhining>
"mapM_ flushICache . pages . codeSpace" FTW! ;-)
Thanks!
"mapM_ flushICache . pages . codeSpace" FTW! ;-)
should be "mapM_ (flushICache . pages) $ codeSpace" I think :)
https://chromiumcodereview.appspot.com/107543003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
