On 2013/12/16 15:30:34, Jakob wrote:
There's definitely a whole lot more that we should clean up long-term, but
this
LGTM for now.
https://codereview.chromium.org/108783005/diff/1/src/zone.cc
File src/zone.cc (right):
https://codereview.chromium.org/108783005/diff/1/src/zone.cc#newcode181
src/zone.cc:181: ASSERT(size > limit_ - position_);
this subtraction is undefined behavior too
https://codereview.chromium.org/108783005/diff/1/src/zone.cc#newcode230
src/zone.cc:230: ASSERT(position_ <= limit_);
this comparison is undefined behavior too
Agreed, but as discussed offline eliminating address arithmetic is whole
different kettle of fish.
https://codereview.chromium.org/108783005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
