On 2013/12/18 08:32:15, Sven Panne wrote:
On 2013/12/18 08:27:59, Sven Panne wrote:
> On 2013/12/18 07:50:38, yurys wrote:
> > Sven, would it make sense to delete deprecated method here following your
> advise
> > in another review (https://codereview.chromium.org/117353002/#msg4) ?
>
> I think so, especially if there is a relatively straightforward replacement.
> Let's aim for a deprecation-free next release...

Hmmmm:

svenpanne@svenpanne[master]:~/chromium/src$ gclient grep GetHeapValue
src/third_party/WebKit/Source/bindings/v8/ScriptProfiler.cpp :
v8::Handle<v8::Value> value = node->GetHeapValue();

It looks like Chrome needs some tweaking before you can remove this.

Yes, it does. It depends on https://codereview.chromium.org/104313002/ which in
turn depends on change in V8 which I just landed
(https://codereview.chromium.org/93843004/)

https://codereview.chromium.org/98633009/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to