On 2013/12/18 07:05:10, Sven Panne wrote:
https://codereview.chromium.org/105313008/diff/1/src/type-info.h
File src/type-info.h (right):
https://codereview.chromium.org/105313008/diff/1/src/type-info.h#newcode45
src/type-info.h:45: static inline bool IsInt32Double(double value) {
On 2013/12/17 16:38:48, Jakob wrote:
> > add operator=() to DoubleRepresentation,
>
> Disagreed. DoubleRepresentation is a union; equality comparison
semantics
are
> caller dependent, so having a default behavior by means of an
operator=()
would
> just be confusing.
Nope, it would exactly be the right thing: The whole point of
DoubleRepresentation is (surprise) a way to fiddle around with the
representation of doubles. So operator=() is extremely well-defined,
namely
equality on the representation.
Still don't agree, and also think the entire issue is utterly unrelated to
the
point of this CL, but since this is the season for making other people
happy...
Done.
https://codereview.chromium.org/105313008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
