Reviewers: dcarney,
Description:
Improve the fix for r18344.
Our toolchains differ in mysterious ways, especially regarding
overloading resolution, templates, etc. :-P This fix avoids a
call/return just for resolution and uses a static_cast instead.
Please review this at https://codereview.chromium.org/118183002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -6 lines):
M src/assembler.cc
Index: src/assembler.cc
diff --git a/src/assembler.cc b/src/assembler.cc
index
1076be0271142cf60f878b332125df4baa5f4286..4ac2fb49eafc41429f4deaf91d16573126c296cb
100644
--- a/src/assembler.cc
+++ b/src/assembler.cc
@@ -1388,15 +1388,11 @@ ExternalReference
ExternalReference::address_of_regexp_stack_memory_size(
#endif // V8_INTERPRETED_REGEXP
-static double math_log_double(double x) {
- return log(x);
-}
-
-
ExternalReference ExternalReference::math_log_double_function(
Isolate* isolate) {
+ typedef double (*d2d)(double x);
return ExternalReference(Redirect(isolate,
- FUNCTION_ADDR(math_log_double),
+ FUNCTION_ADDR(static_cast<d2d>(log)),
BUILTIN_FP_CALL));
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
