On Wed, Dec 18, 2013 at 4:46 PM, Vincent Belliard < [email protected]> wrote:
> This change will trigger OSR faster and most of all, it will trigger OSR > for big functions: > That's the idea :-) > on ARM, with the LUA benchmark, a function is very big and, when ticks > equals 255, the function is still not optimized (and on IA32, it is > optimized just before ticks equals 255). > We explored several ways to change that: > - modify the kOSRCodeSizeAllowancePerTick (as you did), > This seems easiest, and since the limit is arbitrary anyway, hopefully isn't harmful. I'm hoping that we can get rid of the limit entirely at some point (with the help of concurrent recompilation for OSR). > - modify the kCodeSizeMultiplier from 142 to 162, > The kCodeSizeMultiplier is used for a bunch of things and should reflect average relative code size of the different platforms. It'll never be a perfect measure, and I could be convinced to tune it slightly, but 142 -> 162 sounds extreme. (The intention of having this constant is precisely so that optimization/OSR/etc heuristics work roughly the same on all platforms.) > - allow ticks to be greater than 255. > Possible; but if the (hopefully temporary, see above) OSR limit is the only use case, I'd rather not spend the refactoring effort. > It seems that the third solution is better because it removes the limit to > do OSR. It can be linked to the other solutions (and the 3 solutions can be > done together). > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
