Looking good, mostly syntax nits.
https://codereview.chromium.org/104663004/diff/1/src/code-stubs.cc
File src/code-stubs.cc (left):
https://codereview.chromium.org/104663004/diff/1/src/code-stubs.cc#oldcode770
src/code-stubs.cc:770:
Spurious line removal.
https://codereview.chromium.org/104663004/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/104663004/diff/1/src/compiler.cc#newcode94
src/compiler.cc:94: void CompilationInfo::CreateCodeObject() {
That's a funny name. It doesn't actually create a code object, it just
initializes the local variable to undefined...
https://codereview.chromium.org/104663004/diff/1/src/compiler.cc#newcode96
src/compiler.cc:96: isolate());
isolate()->factory()->undefined_value() is already a handle.
https://codereview.chromium.org/104663004/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/104663004/diff/1/src/hydrogen-instructions.h#newcode2297
src/hydrogen-instructions.h:2297: return new(zone)
HCallJSFunction(function, call_kind_value,
nit:
return new(zone) HCallJSFunction(
function, call_kind_value, argument_count, pass_argument_count);
https://codereview.chromium.org/104663004/diff/1/src/hydrogen-instructions.h#newcode2310
src/hydrogen-instructions.h:2310: } else if (index == 1) {
What about just
if (index == 0) return Representation::Tagged();
ASSERT_EQ(1, index);
return Representation::Smi();
https://codereview.chromium.org/104663004/diff/1/src/hydrogen-instructions.h#newcode2323
src/hydrogen-instructions.h:2323: HCallJSFunction(HValue* function,
HValue* call_kind, int argument_count,
Arguments of function declarations on separate lines if they don't fit
on a single line:
HCallJSFunction(HValue* function,
HValue* call_kind,
int argument_count,
...
https://codereview.chromium.org/104663004/diff/1/src/hydrogen-instructions.h#newcode2325
src/hydrogen-instructions.h:2325: : HCall<2>(argument_count),
You can put these on a single line if they fit.
https://codereview.chromium.org/104663004/diff/1/src/hydrogen-instructions.h#newcode2360
src/hydrogen-instructions.h:2360: if (par_index <
descriptor_->environment_length()) {
Why not just ASSERT(par_index < descriptor_->environment_length());
https://codereview.chromium.org/104663004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/104663004/diff/1/src/hydrogen.cc#newcode6755
src/hydrogen.cc:6755: HValue *op_vals[] = { fun, context,
call_kind_value, arity,
HValue*
https://codereview.chromium.org/104663004/diff/1/src/hydrogen.cc#newcode6766
src/hydrogen.cc:6766:
Two newlines between functions
https://codereview.chromium.org/104663004/diff/1/src/hydrogen.cc#newcode6800
src/hydrogen.cc:6800: HValue *op_vals[] = { context(), name_val };
HValue*
https://codereview.chromium.org/104663004/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/104663004/diff/1/src/isolate.cc#newcode1763
src/isolate.cc:1763: delete[]call_descriptors_;
nit: space after [].
https://codereview.chromium.org/104663004/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
https://codereview.chromium.org/104663004/diff/1/src/x64/lithium-x64.cc#newcode1181
src/x64/lithium-x64.cc:1181: descriptor->GetParameterRegister(i - 1));
4-space indent
https://codereview.chromium.org/104663004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
