Revision: 18379
Author: [email protected]
Date: Fri Dec 20 07:46:02 2013 UTC
Log: Fix number of parameters passed into PrepareCallCFunction in code
age stubs
In r16710 Additional parameter (Isolate) was added to parameter lists of
some native functions called from the generated code. However,
corresponding PrepareCallCFunction arguments changed only on i32. This CL
updates other architectures to match actual value.
BUG=None
LOG=None
[email protected]
Review URL: https://codereview.chromium.org/74753006
http://code.google.com/p/v8/source/detail?r=18379
Modified:
/branches/bleeding_edge/src/arm/builtins-arm.cc
/branches/bleeding_edge/src/mips/builtins-mips.cc
/branches/bleeding_edge/src/x64/builtins-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/builtins-arm.cc Thu Dec 5 16:17:44
2013 UTC
+++ /branches/bleeding_edge/src/arm/builtins-arm.cc Fri Dec 20 07:46:02
2013 UTC
@@ -803,7 +803,7 @@
// r1 - isolate
FrameScope scope(masm, StackFrame::MANUAL);
__ stm(db_w, sp, r0.bit() | r1.bit() | fp.bit() | lr.bit());
- __ PrepareCallCFunction(1, 0, r2);
+ __ PrepareCallCFunction(2, 0, r2);
__ mov(r1, Operand(ExternalReference::isolate_address(masm->isolate())));
__ CallCFunction(
ExternalReference::get_make_code_young_function(masm->isolate()), 2);
@@ -836,7 +836,7 @@
// r1 - isolate
FrameScope scope(masm, StackFrame::MANUAL);
__ stm(db_w, sp, r0.bit() | r1.bit() | fp.bit() | lr.bit());
- __ PrepareCallCFunction(1, 0, r2);
+ __ PrepareCallCFunction(2, 0, r2);
__ mov(r1, Operand(ExternalReference::isolate_address(masm->isolate())));
__ CallCFunction(ExternalReference::get_mark_code_as_executed_function(
masm->isolate()), 2);
=======================================
--- /branches/bleeding_edge/src/mips/builtins-mips.cc Thu Dec 5 16:17:44
2013 UTC
+++ /branches/bleeding_edge/src/mips/builtins-mips.cc Fri Dec 20 07:46:02
2013 UTC
@@ -825,7 +825,7 @@
(a0.bit() | a1.bit() | ra.bit() | fp.bit()) & ~sp.bit();
FrameScope scope(masm, StackFrame::MANUAL);
__ MultiPush(saved_regs);
- __ PrepareCallCFunction(1, 0, a2);
+ __ PrepareCallCFunction(2, 0, a2);
__ li(a1, Operand(ExternalReference::isolate_address(masm->isolate())));
__ CallCFunction(
ExternalReference::get_make_code_young_function(masm->isolate()), 2);
@@ -864,7 +864,7 @@
(a0.bit() | a1.bit() | ra.bit() | fp.bit()) & ~sp.bit();
FrameScope scope(masm, StackFrame::MANUAL);
__ MultiPush(saved_regs);
- __ PrepareCallCFunction(1, 0, a2);
+ __ PrepareCallCFunction(2, 0, a2);
__ li(a1, Operand(ExternalReference::isolate_address(masm->isolate())));
__ CallCFunction(
ExternalReference::get_mark_code_as_executed_function(masm->isolate()),
=======================================
--- /branches/bleeding_edge/src/x64/builtins-x64.cc Thu Dec 5 16:17:44
2013 UTC
+++ /branches/bleeding_edge/src/x64/builtins-x64.cc Fri Dec 20 07:46:02
2013 UTC
@@ -604,9 +604,9 @@
__ movq(arg_reg_1, Operand(rsp, kNumSafepointRegisters * kPointerSize));
{ // NOLINT
FrameScope scope(masm, StackFrame::MANUAL);
- __ PrepareCallCFunction(1);
+ __ PrepareCallCFunction(2);
__ CallCFunction(
- ExternalReference::get_make_code_young_function(masm->isolate()),
1);
+ ExternalReference::get_make_code_young_function(masm->isolate()),
2);
}
__ Popad();
__ ret(0);
@@ -637,10 +637,10 @@
__ subq(arg_reg_1, Immediate(Assembler::kShortCallInstructionLength));
{ // NOLINT
FrameScope scope(masm, StackFrame::MANUAL);
- __ PrepareCallCFunction(1);
+ __ PrepareCallCFunction(2);
__ CallCFunction(
ExternalReference::get_mark_code_as_executed_function(masm->isolate()),
- 1);
+ 2);
}
__ Popad();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
