https://codereview.chromium.org/100483006/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/100483006/diff/1/src/arm/lithium-codegen-arm.cc#newcode3445
src/arm/lithium-codegen-arm.cc:3445: __ ldr(result, MemOperand(fp,
StandardFrameConstants::kCallerFPOffset), ne);
Reverted this one.
https://codereview.chromium.org/100483006/diff/1/src/arm/lithium-codegen-arm.cc#newcode3875
src/arm/lithium-codegen-arm.cc:3875: __ vadd(result, input,
kDoubleRegZero, ne);
On 2013/12/13 11:31:14, Rodolph Perfetta wrote:
On 2013/12/12 13:43:23, Sven Panne wrote:
> ... and here.
vadd and especially vsqrt are complex instructions. Complex
instructions don't
interact too well with conditions and the CPU could perform the entire
operation
before discarding the result if the condition is false. So here we'll
be slower
on most modern CPU. If we were in full-codegen that would be
acceptable though.
Done.
https://codereview.chromium.org/100483006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
