https://codereview.chromium.org/123523002/diff/1/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/123523002/diff/1/src/object-observe.js#newcode267
src/object-observe.js:267: if (!observer)
On 2014/01/07 17:27:00, rossberg wrote:
On 2014/01/03 01:00:32, adamk wrote:
> Not sure how much is matters, but this could be IS_NULL()
Yes, please use IS_NULL.
Also, you can just merge this with the other 'if':
if (!IS_NULL(observer) && ObserverIsActive(...)) return true;
Done.
https://codereview.chromium.org/123523002/diff/1/src/object-observe.js#newcode439
src/object-observe.js:439: if (!observer)
On 2014/01/03 01:00:32, adamk wrote:
Ditto
Done.
https://codereview.chromium.org/123523002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
