Reviewers: Benedikt Meurer,
Description:
Removed v8::AssertNoGCScope.
Everything was private, so no object could ever be constructed, which
implies that nobody uses it. Furthermore, it contained a TODO and was
overly complicated, an #ifdef-less simple pimpl idiom would have been
enough.
LOG=y
Please review this at https://codereview.chromium.org/128113002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -30 lines):
M include/v8.h
M src/api.cc
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
17719692ef6c8f0908985c99b1b95f426ea04d19..b2cc9eb8392ca28207164f81e9ede44a344495dd
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4381,24 +4381,6 @@ class V8_EXPORT PersistentHandleVisitor { // NOLINT
/**
- * Asserts that no action is performed that could cause a handle's value
- * to be modified. Useful when otherwise unsafe handle operations need to
- * be performed.
- */
-class V8_EXPORT AssertNoGCScope {
-#ifndef DEBUG
- // TODO(yangguo): remove isolate argument.
- V8_INLINE AssertNoGCScope(Isolate* isolate) {}
-#else
- AssertNoGCScope(Isolate* isolate);
- ~AssertNoGCScope();
- private:
- void* disallow_heap_allocation_;
-#endif
-};
-
-
-/**
* Container class for static utility functions.
*/
class V8_EXPORT V8 {
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
98813e0d536a6cac54ab6277eb967c02a47a7d6c..a8ab69f85dda4d493d179f5aac4a67f5341778ec
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -6164,18 +6164,6 @@ Local<Integer> v8::Integer::NewFromUnsigned(Isolate*
isolate, uint32_t value) {
}
-#ifdef DEBUG
-v8::AssertNoGCScope::AssertNoGCScope(v8::Isolate* isolate) {
- disallow_heap_allocation_ = new i::DisallowHeapAllocation();
-}
-
-
-v8::AssertNoGCScope::~AssertNoGCScope() {
- delete
static_cast<i::DisallowHeapAllocation*>(disallow_heap_allocation_);
-}
-#endif
-
-
void V8::IgnoreOutOfMemoryException() {
EnterIsolateIfNeeded()->set_ignore_out_of_memory(true);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
