Revision: 18493
Author: [email protected]
Date: Wed Jan 8 12:22:42 2014 UTC
Log: Removed v8::AssertNoGCScope.
Everything was private, so no object could ever be constructed, which
implies that nobody uses it. Furthermore, it contained a TODO and was
overly complicated, an #ifdef-less simple pimpl idiom would have been
enough.
LOG=y
[email protected]
Review URL: https://codereview.chromium.org/128113002
http://code.google.com/p/v8/source/detail?r=18493
Modified:
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/src/api.cc
=======================================
--- /branches/bleeding_edge/include/v8.h Tue Jan 7 13:28:33 2014 UTC
+++ /branches/bleeding_edge/include/v8.h Wed Jan 8 12:22:42 2014 UTC
@@ -4380,24 +4380,6 @@
};
-/**
- * Asserts that no action is performed that could cause a handle's value
- * to be modified. Useful when otherwise unsafe handle operations need to
- * be performed.
- */
-class V8_EXPORT AssertNoGCScope {
-#ifndef DEBUG
- // TODO(yangguo): remove isolate argument.
- V8_INLINE AssertNoGCScope(Isolate* isolate) {}
-#else
- AssertNoGCScope(Isolate* isolate);
- ~AssertNoGCScope();
- private:
- void* disallow_heap_allocation_;
-#endif
-};
-
-
/**
* Container class for static utility functions.
*/
=======================================
--- /branches/bleeding_edge/src/api.cc Wed Jan 8 06:53:31 2014 UTC
+++ /branches/bleeding_edge/src/api.cc Wed Jan 8 12:22:42 2014 UTC
@@ -6162,18 +6162,6 @@
i::Handle<i::Object> result =
internal_isolate->factory()->NewNumber(value);
return Utils::IntegerToLocal(result);
}
-
-
-#ifdef DEBUG
-v8::AssertNoGCScope::AssertNoGCScope(v8::Isolate* isolate) {
- disallow_heap_allocation_ = new i::DisallowHeapAllocation();
-}
-
-
-v8::AssertNoGCScope::~AssertNoGCScope() {
- delete
static_cast<i::DisallowHeapAllocation*>(disallow_heap_allocation_);
-}
-#endif
void V8::IgnoreOutOfMemoryException() {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
