https://codereview.chromium.org/99573002/diff/90001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/90001/src/promise.js#newcode65
src/promise.js:65: if (!%_IsConstructCall()) throw
MakeTypeError('not_a_promise', [this]);
Doesn't this break sub classing?
function SubPromise(resolver) {
Promise.call(this, resolver);
}
SubPromise.prototype = {
__proto__: Promise.prototype,
constructor: SubPromise
};
https://codereview.chromium.org/99573002/diff/90001/src/promise.js#newcode280
src/promise.js:280: function PromiseOne(values) {
Rename this to PromiseRace to match?
Why isn't the done check needed any more?
https://codereview.chromium.org/99573002/diff/90001/src/promise.js#newcode309
src/promise.js:309: "chain", PromiseChain,
Any plan to upstream chain into the spec?
https://codereview.chromium.org/99573002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
